Skip to content

Conversation

@joelrobin18
Copy link
Contributor

@joelrobin18 joelrobin18 commented Oct 3, 2025

What changes were proposed in this pull request?

Added a comprehensive Contributing-guide.md file that provides detailed instructions for setting up the project locally for development and testing purposes.

Why are the changes needed?

The project previously lacked documentation on how to set up the development environment locally, run tests, and contribute changes through pull requests. By introducing a comprehensive Contributing-guide.md, we provide step-by-step instructions for environment setup, dependency installation, testing, and the pull request workflow. This would ease the process of contribution for the new contributors.

Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I want to say thank you for this contribution and interest to the project! I left a few comments, actually there are some easier ways to do some things. And it is my bad that project lacks the good contribution guide :(

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (8f3e4fb) to head (70abded).
⚠️ Report is 5 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   86.06%   86.16%   +0.09%     
==========================================
  Files          63       63              
  Lines        2907     2927      +20     
  Branches      327      320       -7     
==========================================
+ Hits         2502     2522      +20     
  Misses        405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: joelrobin18 <[email protected]>
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work, thank you @joelrobin18 !

@SemyonSinchenko
Copy link
Collaborator

I will try to finish #586 and some other minor updates this weekend. Then, next week, we can deploy the new documentation with this beautiful guide for new contributors!

@SemyonSinchenko SemyonSinchenko merged commit 609d642 into graphframes:main Oct 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants