-
Notifications
You must be signed in to change notification settings - Fork 257
feat: add undirected edge motif pattern #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does it close #501 too? I'm trying to understand, what is the difference from the technical point of view... Like if we can detect bidirectional edges, we can detect undirected too by symmetrize the graph, can't we? |
|
@SemyonSinchenko Thanks for clarification. It is undirected edge. I was trying to include in-bound, out-bound edges. |
|
Bidirectional edge is different concept, it should return (0),(1) only which is not this case. I've changed the word to fix this. |
01eb2bc to
5060edb
Compare
|
I've changed the title and the code, but cannot change the branch name. It closes the PR. :( |
It is not a problem. I linked the right issue. |
|
I am not sure whether we need undirected edge for a variable length pattern |
SemyonSinchenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~LGTM
|
@rjurney I want to see this feature in a new release and from my point of view, it is a time to start preparing it. What do you think? |
|
I'm merging it now to make it a part of the new release. |
|
@SemyonSinchenko, what is the timeline for the next release? I hoped I could add informational columns |
|
@goungoun I think we can wait. I was hoping to deliver a new release this week, but we can actually postpone it to the beginning of the next one. |
What changes were proposed in this pull request?
This PR implement undirected motif pattern such as
(u)-[]-(v),(u)-[e]-(v), and(u)-[e*1..3]-(v).Why are the changes needed?
Without the feature, user have to write a long query and union them by themselves as a workaround. After the change, the bidirectional pattern
(u)-[e]-(v)is converted to two patterns(u)-[e]->(v)and(v)-[e]->(u)internally and union the results.