Skip to content

Conversation

@SemyonSinchenko
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko commented Sep 27, 2025

What changes were proposed in this pull request?

This is a big PR but most of changes are not "real" changes.

  • new scala-3 like check for scalafix and corresponding changes
  • updates in docs (should be reviewed)
  • sync of PySpark Connect / Classic with a core
  • pytest now includes testing of most of possible arguments combinations
  • seme pyspark connect/classic were moved from JVM/Connect to pure PySpark
  • new method valudate in PySpark (should be reviewed)
  • new method as_undirected in PySpark (should be reviewed)
  • __repr__ is now shared between connect/classic (should be reviewed)
  • cache is now shared between connect/classic (should be reviewed)
  • persist is now shared between connect/classic (should be reviewed)
  • unpersist is now shared between connect/classic (should be reviewed)
  • inDegrees / outDegrees / degrees are now shared between connect/classic (should be reviewed)
  • nodes alias for vertices in PySpark

Why are the changes needed?

Close #710
Close #706
Close #586
Close #469
Close #715

- Added local Spark distribution to .gitignore - Updated .scalafix
configuration for Scala 3 - Modified .scalafmt configuration for Scala
213 source compatibility - Changed import statements to use wildcard
imports for consistency across files
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 5.26316% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (a2d2a91) to head (78325f6).

Files with missing lines Patch % Lines
...park/sql/graphframes/GraphFramesConnectUtils.scala 0.00% 90 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   86.60%   84.12%   -2.48%     
==========================================
  Files          63       63              
  Lines        2881     2998     +117     
  Branches      321      336      +15     
==========================================
+ Hits         2495     2522      +27     
- Misses        386      476      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SemyonSinchenko SemyonSinchenko changed the title [WIP] chore: docs && sbt [WIP] chore: docs && sync pyspark with core Oct 4, 2025
@SemyonSinchenko SemyonSinchenko changed the title [WIP] chore: docs && sync pyspark with core [WIP] feat: reafctoring of python && docs && sync pyspark with core Oct 5, 2025
@SemyonSinchenko SemyonSinchenko changed the title [WIP] feat: reafctoring of python && docs && sync pyspark with core [WIP] feat: refactoring of python && docs && sync pyspark with core Oct 5, 2025
@SemyonSinchenko SemyonSinchenko self-assigned this Oct 5, 2025
@SemyonSinchenko SemyonSinchenko added scala pyspark-classic GraphFrames on PySpark Classic pyspark-connect GraphFrames on PySpark Connect documentation labels Oct 5, 2025
@SemyonSinchenko SemyonSinchenko marked this pull request as ready for review October 5, 2025 17:29
@SemyonSinchenko SemyonSinchenko changed the title [WIP] feat: refactoring of python && docs && sync pyspark with core feat: refactoring of python && docs && sync pyspark with core Oct 5, 2025
@SemyonSinchenko
Copy link
Collaborator Author

@rjurney @james-willis This one is big, sorry about this. I tried to highlight what should be reviewed

@SemyonSinchenko SemyonSinchenko merged commit 9325c17 into graphframes:main Oct 6, 2025
5 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 710-docs branch October 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation pyspark-classic GraphFrames on PySpark Classic pyspark-connect GraphFrames on PySpark Connect scala

Projects

None yet

3 participants