feat: better TriangleCount #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-willis
requested changes
Sep 24, 2025
Collaborator
|
Ok. lets let Russell review this. |
james-willis
approved these changes
Sep 24, 2025
Collaborator
Author
|
We discussed it with @rjurney , I'm merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While this implementation is better than existing one, it cannot be scaled to power-law graphs. And making a more efficient one is very tricky. I'm recommending to accept this implementation and consider making something like
ApproximateTriangleCountin the future. There are tons of papers about different sampling strategies, assumptions and approximation rate. Different strategies are suitable for different classes of graphs.A proposed in this PR implementation is exactly like one from GraphX. I don't think that there can be anything better for exact counting in most of cases.
Why are the changes needed?
Close #407