feat: add Rocha–Thatte cycle detection algorithm #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
==========================================
- Coverage 87.58% 86.35% -1.24%
==========================================
Files 61 63 +2
Lines 2691 2822 +131
Branches 287 319 +32
==========================================
+ Hits 2357 2437 +80
- Misses 334 385 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
Ill do it in #586 , first is core |
rjurney
approved these changes
Sep 21, 2025
Collaborator
rjurney
left a comment
rjurney
left a comment
There was a problem hiding this comment.
lgtm, Python implementation and docs will follow core.
…ection # Conflicts: # core/src/main/scala/org/graphframes/GraphFrame.scala
+ fix docs generation
+ remove unnecessary distinct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
An implementation of the Rocha–Thatte cycle detection algorithm
Why are the changes needed?
Close #697