Skip to content

Conversation

@SemyonSinchenko
Copy link
Collaborator

What changes were proposed in this pull request?

  • the whole code of GraphX
  • changes in sbt

Why are the changes needed?

Close #679

@SemyonSinchenko SemyonSinchenko self-assigned this Sep 11, 2025
@SemyonSinchenko SemyonSinchenko added scala graphx Anything related to GraphX labels Sep 11, 2025
@james-willis
Copy link
Collaborator

should we change org.apache.spark.graphframes to io.graphframes?

@SemyonSinchenko
Copy link
Collaborator Author

should we change org.apache.spark.graphframes to io.graphframes?

GraphX rely on the many spark internal APIs and I cannot say that it is bad. So, the only way to make it works without copying to much of Spark code to GraphFrames is to use org.apache.spark package...

@SemyonSinchenko
Copy link
Collaborator Author

image

There are a lot of such a things. Yes, usage of them may make project more fragile. From the other side, we do not need to implement and rewrite everything. We may consider it as a tech debt. What do you think @james-willis ?

@james-willis
Copy link
Collaborator

makes sense to me. we do a lot of that in sedona.

I think the best strategy is to keep as much of it as possible outside the org.apache.spark namespace but I don't want to put that burden on you or block the progress towards more valuable code changes.

@SemyonSinchenko SemyonSinchenko merged commit c352149 into graphframes:master Sep 12, 2025
5 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 679-graphx branch September 12, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphx Anything related to GraphX scala

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: move GraphX to GraphFrames

2 participants