chore: add useLabelsAsComponents configuration for connected components #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new configuration option `spark.graphframes.useLabelsAsComponents` to allow connected components to use labels as components. Updated the logic in `ConnectedComponents` and added relevant test cases for both enabled and disabled configurations.
Collaborator
Author
|
cc: @Kimahriman This PR is aiming to fix the problem you faced in apache/sedona#1919 I added a test for the case of string labels and with setting a conf to false CC returns LongType IDs. |
Contributor
|
LGTM, maybe just mention the components are longs when the config is false in the description? |
Collaborator
Author
Done! |
james-willis
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduced a new configuration option
spark.graphframes.useLabelsAsComponentsto allow connected components to use labels as components. Updated the logic inConnectedComponentsand added relevant test cases for both enabled and disabled configurations.Why are the changes needed?
Close #620