feat: add a new mixin WithMaxIter and propogate it to GraphX CC #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
Author
I spent about 15 minutes for it :) |
Contributor
|
lgtm
El sáb, 19 abr 2025, 17:13, Sem ***@***.***> escribió:
… I thought we weren't going to invert time into GraphX anymore.
I spent about 15 minutes for it :)
I would like to close as much issues as possible (#559
<#559>). This one (#419
<#419>) was trivial,
just couple of lines of real code. Plus I added a MixIn as part of #560
<#560>. Does it sound OK
to accept this fix? @SauronShepherd <https://github.com/SauronShepherd>
—
Reply to this email directly, view it on GitHub
<#590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCN67YGKORVZMW5QZVHF5L22JRYVAVCNFSM6AAAAAB3OUSLUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWG42DMNRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*SemyonSinchenko* left a comment (graphframes/graphframes#590)
<#590 (comment)>
I thought we weren't going to invert time into GraphX anymore.
I spent about 15 minutes for it :)
I would like to close as much issues as possible (#559
<#559>). This one (#419
<#419>) was trivial,
just couple of lines of real code. Plus I added a MixIn as part of #560
<#560>. Does it sound OK
to accept this fix? @SauronShepherd <https://github.com/SauronShepherd>
—
Reply to this email directly, view it on GitHub
<#590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCN67YGKORVZMW5QZVHF5L22JRYVAVCNFSM6AAAAAB3OUSLUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWG42DMNRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
rjurney
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
WithMaxIterto avoid code duplicationmaxIterto GraphX-based implementation of ConnectedComponentsWhy are the changes needed?
As described in issue. Close #419
cc: @Ishitori
cc: @SauronShepherd could you take a look too?