Replace bintray #385
Replace bintray #385
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 18 18
Lines 870 870
Branches 53 53
=======================================
Hits 794 794
Misses 76 76 ☔ View full report in Codecov by Sentry. |
project/plugins.sbt
Outdated
| @@ -1,5 +1,5 @@ | |||
| // You may use this file to add plugin dependencies for sbt. | |||
| resolvers += "Spark Packages repo" at "https://dl.bintray.com/spark-packages/maven/" | |||
| resolvers += "Spark Packages repo" at "https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/" | |||
There was a problem hiding this comment.
This should be changed to https://repos.spark-packages.org/ instead. See: http://apache-spark-user-list.1001560.n3.nabble.com/Bintray-replacement-for-spark-packages-org-td40128.html
There was a problem hiding this comment.
I'm not sure if I have permissions to re-request a review, but I've made this change and this PR is ready for review again.
|
Can this PR be reviewed and merged? With bintray down, it's impossible to include package from the maven repository. |
|
The issue is still there for instance if you need to import it from cloud platforms. E.g. in Google Cloud Dataproc, AFAIK you cannot specify the locaton of the dependencies as it always goes to Maven, therefore it fails to create the cluster with the GraphFrames dependency. I really hope the PR can be merged soon :-) |
|
Is there anything else I need to do to get this merged? Happy to help if there's any way I can help. |
|
Merged into master. Thanks!! |
7 participants
Bintray is being deprecated which will cause builds to fail because there are dependencies on Bintray: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
Also see #384
This PR replaces the usages of Bintray with
repo.scala-sbt.orgwhich I found from this issue on SBT about replacing Bintray. I was able to run a build locally with these changes during the April 26 Bintray brownout.