Merged
Conversation
Collaborator
|
Wow!! 🎉 Thanks for all your work and for finally resolving this... |
This was referenced Jul 7, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388
I won't share just how many dead-ends I ended going down to resolve this. But I think I've cracked it now.
tl;dr For reasons that I don't fully understand, we can't wrap the whole
draw_legend()function inrecordGraphics()without messing up source calls (which is what #388 was ultimately about.) At the same time, simply wrapping the finallegend/gradient_legendcalls didn't work either for the Positron case (per #377). However, it turns out that the compromise solution is to wrap the fake legend construction (which we need for calculating the plot offset for outside legend placement), the offset calculation, and the final legend plotting call together... but only these steps.I operationalised this by creating a new internal
recordGraphics(tinylegend(...), ...)function.