Skip to content

Point-range plots with type="pointrange"#35

Merged
grantmcdermott merged 5 commits intograntmcdermott:mainfrom
vincentarelbundock:pointrange
Jun 19, 2023
Merged

Point-range plots with type="pointrange"#35
grantmcdermott merged 5 commits intograntmcdermott:mainfrom
vincentarelbundock:pointrange

Conversation

@vincentarelbundock
Copy link
Collaborator

@vincentarelbundock vincentarelbundock commented Jun 18, 2023

Partially fulfils Issue #25

@grantmcdermott
Copy link
Owner

grantmcdermott commented Jun 18, 2023

Dig it. Lmk when it's ready for review.

Fwiw I don't know why the density plot tests are failing in the Ubuntu-dev CI run. I observed the same behaviour in #34 but haven't investigated properly yet.

@vincentarelbundock
Copy link
Collaborator Author

vincentarelbundock commented Jun 18, 2023

Cool. I added a NEWS item and think this is ready for review. Happy to make changes, of course.

I don't know about the error. I see this in R-devel NEWS, but don't know if it can explain:

‘density()’ more consistently computes grid values for the FFT based convolution, following Robert Schlicht's analysis and proposal in PR#18337, correcting density values typically by a factor of about 0.999. Optional ‘old.coords=TRUE’ provides back compatibility.

grantmcdermott
grantmcdermott requested changes Jun 19, 2023
View reviewed changes
Copy link
Owner

@grantmcdermott grantmcdermott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple review comments and questions. Feel free to push back.

grantmcdermott
grantmcdermott requested changes Jun 19, 2023
View reviewed changes
Copy link
Owner

@grantmcdermott grantmcdermott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One or two little things I just caught. Happy to merge thereafter.

@grantmcdermott grantmcdermott merged commit 8ed8375 into grantmcdermott:main Jun 19, 2023
@grantmcdermott
Copy link
Owner

grantmcdermott commented Jun 19, 2023

Very stoked to have this added. Thanks Vincent.

(Next step: ribbons!)

@grantmcdermott grantmcdermott changed the title Point-range plots with type="pr" Point-range plots with type="pointrange" Jun 19, 2023
@vincentarelbundock
Copy link
Collaborator Author

vincentarelbundock commented Jun 19, 2023

Yay!

@zeileis
Copy link
Collaborator

zeileis commented Jun 19, 2023

Very cool!

This was referenced Jun 19, 2023
Closed
Closed
@grantmcdermott grantmcdermott mentioned this pull request Jul 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantmcdermott grantmcdermott grantmcdermott requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vincentarelbundock @grantmcdermott @zeileis