This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Ignore incompatible targets#100
Merged
siddharthab merged 1 commit intomasterfrom Jul 27, 2022
Merged
Conversation
Currently incompatible targets are included by the aspect until the linked PR lands. In this case the targets don't have CcInfo, so we can use that as a workaround for ignoring them for now.
Collaborator
Author
|
The migration issue is actually an issue in bazel itself being incompatible with |
Collaborator
Author
|
The upstream fix was merged and should be in 5.3+, so we can probably skip this |
Collaborator
|
Thanks for the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently incompatible targets are included by the aspect until the
linked PR lands. In this case the targets don't have CcInfo, so we can
use that as a workaround for ignoring them for now.