Skip to content

Conversation

@tsloughter
Copy link
Contributor

No description provided.

@tsloughter tsloughter requested a review from a team as a code owner July 13, 2024 10:10
@tsloughter tsloughter requested review from pablochacin and removed request for a team July 13, 2024 10:10
@CLAassistant
Copy link

CLAassistant commented Jul 13, 2024

CLA assistant check
All committers have signed the CLA.

@pablochacin pablochacin self-assigned this Jul 16, 2024
@pablochacin
Copy link
Contributor

@tsloughter thanks for your interest in contributing to the project.

I checked and changing "Endpoint" by "Endpoints" generates the following error: unknown kind: 'Endpoints' in the tests because the fake REST mapper must also be updated.

@tsloughter
Copy link
Contributor Author

@pablochacin ok, will fix 👍

@tsloughter tsloughter force-pushed the get-endpoints-plural branch from 2c1b275 to af845dd Compare July 17, 2024 11:45
@tsloughter
Copy link
Contributor Author

Fixed.

Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablochacin pablochacin merged commit 5be1402 into grafana:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants