fix linting errors and add linter as CI check #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javaducky
suggested changes
Aug 23, 2023
Signed-off-by: Jorge Turrado <[email protected]>
javaducky
approved these changes
Aug 23, 2023
Contributor
javaducky
left a comment
javaducky
left a comment
There was a problem hiding this comment.
LGTM! Thank you for correcting that.
Contributor
Author
np, my error, my fix 😄 you're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my previous commit I introduced an error because I duplicated an already existing import.
This PR fixes that issue and also adds the linter as CI check to prevent this incident in the future