Skip to content

Conversation

@JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented Aug 23, 2023

Signed-off-by: Jorge Turrado [email protected]

Fixes #100

Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@javaducky javaducky merged commit ad619e1 into grafana:main Aug 23, 2023
@JorTurFer
Copy link
Contributor Author

I have introduced by error a duplicated import 🤦
I've opened another PR fixing it: #102

@JorTurFer
Copy link
Contributor Author

I do confirm that now it works in-cluster, we are already using this extension and we can create resources inside the cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xk6-kubernetes extension can't be used in-cluster

3 participants