This repository was archived by the owner on Jul 19, 2023. It is now read-only.
refactor: cmd/phlare/main.go#566
Merged
cyriltovena merged 4 commits intografana:mainfrom Mar 9, 2023
Merged
Conversation
auto-merge was automatically disabled
March 7, 2023 10:35
Head branch was pushed to by a user without write access
AkshayAwate
force-pushed
the
refactor-main
branch
from
9bfca27 to
08b4d13
Compare
Contributor
|
@cyriltovena I guess you need to approve the first-time contributor's first PR to run the GitHub actions. |
AkshayAwate
requested review from
cyriltovena and
simonswine
and removed request for
cyriltovena and
simonswine
0xPoe
approved these changes
Mar 9, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* refactor: cmd/phlare/main.go * Update main.go * refactor: cmd/phlare/main.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that identical segments of code are being employed in multiple instances, it is better to utilize the concept of functions, whereby the code is encapsulated within a named block that can be invoked at various points within the program.