Upgrade dskit to remove dependency on weaveworks/common#5672
Merged
Conversation
charleskorn
force-pushed
the
charleskorn/weaveworks-common-to-dskit-migration
branch
2 times, most recently
from
205baba to
1d21a71
Compare
charleskorn
force-pushed
the
charleskorn/weaveworks-common-to-dskit-migration
branch
from
1d21a71 to
c031ac4
Compare
pracucci
approved these changes
Aug 4, 2023
Collaborator
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Very easy to review, well done! I reviewed also changes to vendor/ and LGTM. Let's go 🚀 !
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR upgrades dskit and replaces use of packages from weaveworks/common with their migrated equivalents in dskit. See grafana/dskit#342 for more details.
If this PR needs to be rebuilt, I used
rewrite.sh(source) to generate most of these changes.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]