Skip to content

Add option to disable ring health check in the readiness endpoint#48

Merged
pracucci merged 1 commit intomainfrom
allow-to-disable-readiness-check-ring-healthy
Aug 3, 2021
Merged

Add option to disable ring health check in the readiness endpoint#48
pracucci merged 1 commit intomainfrom
allow-to-disable-readiness-check-ring-healthy

Conversation

@pracucci
Copy link
Copy Markdown
Collaborator

@pracucci pracucci commented Aug 2, 2021

What this PR does:
We're rolling out ingesters in multiple zones. When we do it, multiple ingesters in the same zone can be rolled out simultaneously but their readiness endpoint will not succeed until all ingesters in the ring are ACTIVE and healthy.

In this PR I'm proposing to add an option to disable this check.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested review from bboreham and pstibrany August 2, 2021 13:11
Copy link
Copy Markdown
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

Copy link
Copy Markdown
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@pracucci pracucci merged commit 2dd9f6c into main Aug 3, 2021
@pracucci pracucci deleted the allow-to-disable-readiness-check-ring-healthy branch August 3, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants