Skip memberlist zone-aware routing if there is a zone with members but no alive bridges#13664
Merged
Skip memberlist zone-aware routing if there is a zone with members but no alive bridges#13664
Conversation
pracucci
commented
Nov 26, 2025
| * [FEATURE] Distributor: add `-distributor.otel-label-name-underscore-sanitization` and `-distributor.otel-label-name-preserve-underscores` that control sanitization of underscores during OTLP translation. #13133 | ||
| * [FEATURE] Query-frontends: Automatically adjust features used in query plans generated for remote execution based on what the available queriers support. #13017 #13164 #13544 | ||
| * [FEATURE] Memberlist: Add experimental support for zone-aware routing, in order to reduce memberlist cross-AZ data transfer. #13129 | ||
| * [FEATURE] Memberlist: Add experimental support for zone-aware routing, in order to reduce memberlist cross-AZ data transfer. #13129 #13651 #13664 |
Collaborator
Author
There was a problem hiding this comment.
Note to reviewers: I've added the PR #13651 which was part of this work but I didn't include previously.
pracucci
force-pushed
the
update-memberlist-and-dskit
branch
from
6b785e6 to
9a3de6a
Compare
pracucci
commented
Nov 27, 2025
| @@ -332,7 +331,7 @@ require ( | |||
| github.com/stretchr/objx v0.5.2 // indirect | |||
| github.com/uber/jaeger-lib v2.4.1+incompatible // indirect | |||
| github.com/xhit/go-str2duration/v2 v2.1.0 // indirect | |||
| go.etcd.io/etcd/api/v3 v3.5.4 // indirect | |||
| go.etcd.io/etcd/api/v3 v3.6.6 // indirect | |||
Collaborator
Author
There was a problem hiding this comment.
Note to reviewers: inherited from dskit (grafana/dskit@0d0dd15)
Contributor
|
💻 Deploy preview deleted (Skip memberlist zone-aware routing if there is a zone with members but no alive bridges). |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
colega
approved these changes
Nov 27, 2025
tacole02
reviewed
Nov 27, 2025
Contributor
tacole02
left a comment
tacole02
left a comment
There was a problem hiding this comment.
Docs look good! I left a few minor suggestions. Thank you!
1 task
pracucci
added a commit
to grafana/dskit
that referenced
this pull request
Nov 28, 2025
**What this PR does**: Fix panic found by cursor that, at this point, is definitely better than us: grafana/mimir#13664 (comment) **Which issue(s) this PR fixes**: N/A **Checklist** - [ ] Tests updated Signed-off-by: Marco Pracucci <[email protected]>
…t no alive bridges Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Co-authored-by: Taylor C <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
update-memberlist-and-dskit
branch
from
01f4745 to
7568146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Update memberlist and dskit to get:
I've updated
MimirMemberlistBridgeZoneUnavailablealertforduration because after this PR having no running bridges in a zone will be less severe.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Update memberlist/dskit and etcd stack, adopt new memberlist node-selection API, improve networking/transport, and relax the bridge-unavailable alert timing.
NodeStateand replaceNodeSelectionDelegate.SelectNodewithSelectNodes(selected, preferred); update k-random node selection accordingly.hash_revision, snapshotversion, statusstorageVersion/dbSizeQuota/downgradeInfo).Maintenance.DowngradeandSnapshotWithVersion; refine retry/backoff, auth token refresh, error handling (ContextError).go-proxyproto(newConnPolicyFunc, improved Accept/reader, write path) and keep-alive handling with OS-specific fixes; socket option handling for non-Linux.MimirMemberlistBridgeZoneUnavailablealertforduration.Written by Cursor Bugbot for commit 7568146. This will update automatically on new commits. Configure here.