Closed
Conversation
krajorama
added a commit
that referenced
this pull request
Jul 24, 2025
For testing #12152 Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
that referenced
this pull request
Jul 24, 2025
…2183) For testing #12152 Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
that referenced
this pull request
Jul 24, 2025
For testing #12152 Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
that referenced
this pull request
Jul 25, 2025
Change the test to exercise labels much more. Use 2000 series instead of 1. Use 1 sample per series instead of 1000. Use more realistic number of labels per series. Make 10% of series use exponential histograms and let those have 10 exemplars per series instead of 1 per series. Add exemplars to the first sample for each series. Related to #12152 --------- Signed-off-by: György Krajcsovits <[email protected]> Co-authored-by: Copilot <[email protected]>
krajorama
added a commit
that referenced
this pull request
Jul 28, 2025
Change the test to exercise labels much more. Use 2000 series instead of 1. Use 1 sample per series instead of 1000. Use more realistic number of labels per series. Make 10% of series use exponential histograms and let those have 10 exemplars per series instead of 1 per series. Add exemplars to the first sample for each series. Related to #12152 --------- Signed-off-by: György Krajcsovits <[email protected]> Co-authored-by: Copilot <[email protected]> # Conflicts: # pkg/distributor/otel_test.go
aknuds1
reviewed
Jul 31, 2025
| } | ||
|
|
||
| func newOTLPMimirConverter() *otlpMimirConverter { | ||
| func newOTLPMimirConverter(appender *otlpappender.CombinedAppender) *otlpMimirConverter { |
Contributor
There was a problem hiding this comment.
[Nit] Is there any benefit to take the otlpappender.CombinedAppender argument? Can't it just be instantiated in this function, instead of leaving it to the caller?
Contributor
Author
There was a problem hiding this comment.
Maybe, I haven't spent a lot of time on it, not sure why it's so complicated currently.
krajorama
added a commit
that referenced
this pull request
Aug 4, 2025
Prepare for the rewrite of the OTLP translator upstream in prometheus/prometheus#16951 by adding an end-to-end test to check for regressions. Related to #12152. Also switch from raw JSON in the test to building the payload in code and marshaling to protobuf. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]> # Conflicts: # go.mod # go.sum # vendor/github.com/prometheus/prometheus/storage/remote/otlptranslator/prometheusremotewrite/helper.go # vendor/github.com/prometheus/prometheus/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go # vendor/modules.txt
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]> # Conflicts: # pkg/distributor/otel.go # pkg/distributor/otel_test.go # pkg/distributor/push_test.go
Signed-off-by: György Krajcsovits <[email protected]>
krajorama
force-pushed
the
krajo/otlp-to-appender
branch
from
e463606 to
0f12324
Compare
3 tasks
Contributor
Author
|
outdated, new PR: #12652 |
krajorama
added a commit
that referenced
this pull request
Sep 9, 2025
Prepare for the rewrite of the OTLP translator upstream in prometheus/prometheus#16951 by adding an end-to-end test to check for regressions. Related to #12152. Also switch from raw JSON in the test to building the payload in code and marshaling to protobuf. Signed-off-by: György Krajcsovits <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt prometheus/prometheus#16855 .
Will have to be updated to solution in prometheus/prometheus#16951
Remove copy of Prometheus OTLP translator code from Mimir as it is now storage independent in (mimir-)Prometheus.
Add new CombinedAppender implementation that uses the mimirpb.PreAllocTimeseries as target.