Upgrade dskit to use packages migrated from weaveworks/common#10164
Merged
Upgrade dskit to use packages migrated from weaveworks/common#10164
Conversation
charleskorn
force-pushed
the
charleskorn/weaveworks-common-to-dskit-migration
branch
from
d6008a4 to
796ae69
Compare
kavirajk
approved these changes
Aug 7, 2023
Contributor
kavirajk
left a comment
kavirajk
left a comment
There was a problem hiding this comment.
LGTM. Thanks @charleskorn for the PR ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR upgrades dskit and replaces use of packages from weaveworks/common with their migrated equivalents in dskit. See grafana/dskit#342 for more details.
Note that Loki still uses some packages from weaveworks/common that I haven't migrated (
awsandtest) - I'll migrate these separately.If this PR needs to be rebuilt, I used
rewrite.sh(source) to generate most of these changes.Which issue(s) this PR fixes:
(none)
Special notes for your reviewer:
(none)
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR