Skip to content

Comments

Remove unused receivers#1685

Merged
heitortsergent merged 3 commits intografana:mainfrom
KAZYPinkSaurus:main
Apr 4, 2025
Merged

Remove unused receivers#1685
heitortsergent merged 3 commits intografana:mainfrom
KAZYPinkSaurus:main

Conversation

@KAZYPinkSaurus
Copy link
Contributor

@KAZYPinkSaurus KAZYPinkSaurus commented Aug 5, 2024

What?

Remove unused receiver.
I hope this change helps you.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

nothing.

@KAZYPinkSaurus KAZYPinkSaurus changed the title Remove unused receiver Remove unused receivers Aug 5, 2024
@KAZYPinkSaurus KAZYPinkSaurus marked this pull request as ready for review August 5, 2024 09:18
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2025

CLA assistant check
All committers have signed the CLA.

@heitortsergent
Copy link
Collaborator

Hi @KAZYPinkSaurus! Thanks for the contribution, and sorry I missed this when you first opened it.

It looks like we made some changes to these files, would you mind merging main to your branch? And if you don't mind, we require people to sign the CLA before we can accept any contributions, you can view the document and sign it in the link from the comment above.

Thanks! 🙇

@KAZYPinkSaurus KAZYPinkSaurus requested a review from a team as a code owner March 21, 2025 12:01
@KAZYPinkSaurus KAZYPinkSaurus requested review from mstoykov and oleiade and removed request for a team March 21, 2025 12:02
@heitortsergent
Copy link
Collaborator

Hi @KAZYPinkSaurus! It looks like we still need you to sign the CLA agreement before we can merge this. Would you mind checking the link in the comment from the CLAassistant?

Thanks! 🙇

@KAZYPinkSaurus
Copy link
Contributor Author

@heitortsergent
Hi! I’ve signed the CLA, but it looks like the workflow status hasn’t updated yet. Is there anything else I should do on my end?

thank you.
image

@heitortsergent
Copy link
Collaborator

@jdbaldry would you be able to help us here? Could the CLA not be updating because the PR was opened too long ago? 😖

@jdbaldry
Copy link
Contributor

jdbaldry commented Apr 2, 2025

@heitortsergent
Copy link
Collaborator

@jdbaldry I tried the instructions to have the assistant run the check again, but it doesn't seem to be working. :( Should we try to close and open a new PR?

@jdbaldry
Copy link
Contributor

jdbaldry commented Apr 2, 2025

I think it may be because there are two different authors in the commit log: https://github.com/grafana/k6-docs/pull/1685/commits

@jdbaldry
Copy link
Contributor

jdbaldry commented Apr 2, 2025

If either you or @KAZYPinkSaurus can rewrite the history to remove that commit, perhaps by squashing all the rest together, then the CLA will pass.

@heitortsergent
Copy link
Collaborator

@KAZYPinkSaurus let me know if you can do what @jdbaldry suggested and squash the commits? I don't think I can do it since this is coming from your fork branch. :(

@jdbaldry jdbaldry requested a review from a team as a code owner April 4, 2025 08:14
@jdbaldry jdbaldry requested review from e-fisher and going-confetti and removed request for a team April 4, 2025 08:14
@jdbaldry
Copy link
Contributor

jdbaldry commented Apr 4, 2025

Sorry to those accidentally added as initial reviewers. I performed a git filter-repo mailmap rewrite of the email but forgot to rebase on origin/main before I pushed and so I accidentally pinged you all for review thanks to the divergent histories.

In case anyone is interested in the steps I took:

git clone [email protected]:KAZYPinkSaurus/k6-docs.git k6-docs-filter-repo # git-filter-repo prefers to operate in a fresh clone
cd k6-docs-filter-repo/
git filter-repo --mailmap <(echo "KAZYPinkSaurus <[email protected]> <[email protected]>") # Format is <NAME> <NEW EMAIL> <OLD EMAIL>

@heitortsergent
Copy link
Collaborator

Thank you so much @jdbaldry! 🙇

And thank you for your patience on this @KAZYPinkSaurus, sorry about the long wait. 🙇

@heitortsergent heitortsergent merged commit 5d671e9 into grafana:main Apr 4, 2025
2 checks passed
@heitortsergent heitortsergent mentioned this pull request Apr 7, 2025
5 tasks
schalksnyman pushed a commit to schalksnyman/k6-docs that referenced this pull request Jul 2, 2025
* remove unsed receiver

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants