Update methods on Page type to return Promises #48
Conversation
allansson
requested review from
ankur22,
codebien,
inancgumus,
joanlopez,
ka3de,
mstoykov,
nicolevanderhoeven,
olegbespalov and
oleiade
as code owners
allansson
removed request for
codebien,
joanlopez,
ka3de,
mstoykov,
nicolevanderhoeven,
olegbespalov and
oleiade
| * @param options | ||
| */ | ||
| goto(url: string, options?: NavigationOptions): Promise<null | Response>; | ||
| goto(url: string, options?: NavigationOptions): Promise<Response | null>; |
There was a problem hiding this comment.
This ordering makes more sense. Is this also idiomatic?
There was a problem hiding this comment.
I would say so, yes.
My gut feeling for how it "should" be is:
- Complex, named types
- Primitives
nullandundefined
For example:
function abc(): Alphabet | string | nullThe point is to keep the thing that the user is looking for up front, so that it's easier to find functions that return what you want. And you're unlikely to want to use a function because it returns null or undefined.
There was a problem hiding this comment.
The counter-argument is that you should draw attention to the exceptional value (null, undefined or custom error types) to highlight the fact that the function has some special cases that you need to handle.
There was a problem hiding this comment.
But what I see most often is that null and undefined go at the end. 🙂
3 participants
Please fill in this template.
pnpm test <package to test>.