Add single() to k6/html selections by rohan-patnaik · Pull Request #6002 · grafana/k6

rohan-patnaik · 2026-05-16T18:56:18Z

Adds selection.single(selector) to k6/html, backed by goquery.Single(selector).

This gives scripts a direct way to select only the first matching descendant instead of collecting all matches with find(selector).first().

Closes #2161.

Testing:

make lint
go test ./js/modules/k6/html
go test -race ./js/modules/k6/html
go test ./js/modules/k6/http
GOMAXPROCS=1 go test -p 1 -timeout 1600s ./internal/js/modules/k6/browser/tests/...
Retried full make check; lint passes, but the repo-wide race suite still fails locally when browser tests run with the default go test ./... parallelism.

Checklist:

Self-reviewed
Added tests
Ran full make check

cla-assistant · 2026-05-16T18:56:33Z

All committers have signed the CLA.

cla-assistant · 2026-05-16T18:56:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

Pull request overview

This PR adds a new selection.single(selector) API to the k6/html module, intended to provide an optimized equivalent to find(selector).first() by leveraging goquery.Single(selector).

Changes:

Added Selection.Single(selector string) to js/modules/k6/html backed by goquery.Single(selector).
Added JS-facing tests for the new single() selection method.
Modernized a non-Linux build-tag file by removing the legacy // +build directive.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`js/modules/k6/html/html.go`	Adds the new `Selection.Single()` method that powers `selection.single()` in JS.
`js/modules/k6/html/html_test.go`	Adds unit tests covering `single()` basic behavior, chaining, and no-match behavior.
`internal/js/modules/k6/browser/common/kill_other.go`	Removes legacy build tag comment, relying on `//go:build` only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

inancgumus · 2026-06-09T16:38:15Z

Hi @rohan-patnaik, can you check the CoPilot review suggestions, please? Thanks!

Closes grafana#2161

rohan-patnaik · 2026-06-09T17:26:41Z

@inancgumus addressed the Copilot suggestions and updated the branch.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

rohan-patnaik · 2026-06-09T17:58:36Z

@inancgumus resolved the additional Copilot comments.
Hopefully no more feedback comments!

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

inancgumus · 2026-06-10T19:38:41Z

@mstoykov, I've approved this PR.

mstoykov

LGTM! Thank you for the change!

Would you like to open a PR to add thsi to the docs as well

rohan-patnaik · 2026-06-11T08:19:59Z

Thanks @mstoykov! Will look into the docs update once I have a bit more bandwidth.

inancgumus · 2026-06-11T12:32:04Z

@rohan-patnaik, you can use the k6-docs skill from the grafana/skills repository for writing idiomatic docs.

rohan-patnaik requested a review from a team as a code owner May 16, 2026 18:56

rohan-patnaik requested review from inancgumus and mstoykov and removed request for a team May 16, 2026 18:56

rohan-patnaik temporarily deployed to azure-trusted-signing June 5, 2026 08:18 — with GitHub Actions Inactive

rohan-patnaik temporarily deployed to azure-trusted-signing June 5, 2026 08:22 — with GitHub Actions Inactive

inancgumus requested a review from Copilot June 9, 2026 16:26

Copilot started reviewing on behalf of inancgumus June 9, 2026 16:26 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread js/modules/k6/html/html.go Outdated

Comment thread js/modules/k6/html/html_test.go Outdated

Comment thread js/modules/k6/html/html_test.go

Add single() to k6/html selections

614defa

Closes grafana#2161

rohan-patnaik force-pushed the add-html-single-selection branch from 98a0400 to 7a78188 Compare June 9, 2026 17:26

rohan-patnaik force-pushed the add-html-single-selection branch from 7a78188 to a23361b Compare June 9, 2026 17:33

inancgumus requested a review from Copilot June 9, 2026 17:39

Copilot started reviewing on behalf of inancgumus June 9, 2026 17:39 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread js/modules/k6/html/html.go

fix(html): keep single selection to one match

5a6a7d7

rohan-patnaik force-pushed the add-html-single-selection branch from a23361b to 5a6a7d7 Compare June 9, 2026 17:48

inancgumus requested a review from Copilot June 9, 2026 18:24

Copilot started reviewing on behalf of inancgumus June 9, 2026 18:24 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

rohan-patnaik temporarily deployed to azure-trusted-signing June 9, 2026 18:30 — with GitHub Actions Inactive

rohan-patnaik temporarily deployed to azure-trusted-signing June 9, 2026 18:32 — with GitHub Actions Inactive

inancgumus approved these changes Jun 9, 2026

View reviewed changes

mstoykov approved these changes Jun 11, 2026

View reviewed changes

mstoykov added the documentation-needed A PR which will need a separate PR for documentation label Jun 11, 2026

mstoykov added this to the v2.1.0 milestone Jun 11, 2026

mstoykov merged commit 8b92155 into grafana:master Jun 11, 2026
51 of 54 checks passed

BrewTestBot mentioned this pull request Jun 30, 2026

k6 2.1.0 Homebrew/homebrew-core#290548

Merged

Uh oh!

Conversation

rohan-patnaik commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant Bot commented May 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inancgumus commented Jun 9, 2026

Uh oh!

rohan-patnaik commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rohan-patnaik commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

inancgumus commented Jun 10, 2026

Uh oh!

mstoykov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rohan-patnaik commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inancgumus commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rohan-patnaik commented May 16, 2026 •

edited

Loading

cla-assistant Bot commented May 16, 2026 •

edited

Loading

rohan-patnaik commented Jun 11, 2026 •

edited

Loading