Fix double completion bug#124
Merged
Merged
Conversation
Duologic
approved these changes
Aug 29, 2023
Duologic
reviewed
Aug 29, 2023
Duologic
left a comment
Duologic
left a comment
Contributor
There was a problem hiding this comment.
This fixes it for one of my use cases, but I have one more that still shows doubles with this PR.
Contributor
|
And I can now reproduce it, just need one more import layer 😿 local g = import 'hello3.jsonnet';
{
a: g.hello.<tab>,
}// hello.jsonnet
{
hello: {
to: {
the: 'world',
},
},
}// hello2.jsonnet
{ hello: (import 'hello.jsonnet').hello }// hello3.jsonnet
import 'hello2.jsonnet' |
woops Closes #122
julienduchesne
force-pushed
the
julienduchesne/fix-double-completion-bug
branch
from
August 31, 2023 18:05
f508226 to
b6e30b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
woops
Closes #122