Skip to content

Fix FrameTypeVersion comparisons across major versions - #1613

Merged
ryantxu merged 2 commits into
grafana:mainfrom
winklemad:fix/frame-type-version-ordering-c4
Sep 8, 2026
Merged

ryantxu merged 2 commits into
grafana:mainfrom
winklemad:fix/frame-type-version-ordering-c4

Conversation

@winklemad

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Updates FrameTypeVersion.Less and Greater to compare the major component first and the minor component only when the majors are equal. This prevents contradictory ordering results across major versions.

Adds table-driven regression coverage for equal versions, minor-version ordering, and cross-major comparisons with opposing minor values.

AI assistance disclosure: OpenAI Codex assisted with investigating the bug, drafting the fix and regression tests, and running validation. I reviewed and understand every changed line and can explain and maintain the contribution.

Which issue(s) this PR fixes:

Fixes #1612

Special notes for your reviewer:

None.

@cla-assistant

cla-assistant Bot commented Jul 26, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Jul 26, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant

cla-assistant Bot commented Jul 26, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@grafana-catalog-project-bot grafana-catalog-project-bot Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Jul 27, 2026
@ryantxu
ryantxu enabled auto-merge (squash) September 8, 2026 13:02
@ryantxu
ryantxu merged commit 29b637d into grafana:main Sep 8, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FrameTypeVersion comparisons are incorrect across major versions

2 participants