test: guard fixture case groups#238
Merged
zeitlinger merged 3 commits intomainfrom Apr 27, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <[email protected]>
zeitlinger
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a registry-level test to ensure tests/cases/* top-level fixture groups remain aligned with registered built-in check names (allowing general as the sole non-check group), preventing silent drift between fixture layout and linter identities.
Changes:
- Introduce
test_case_groups_match_registered_checksto validatetests/casesdirectory names againstbuiltin()check names plusgeneral.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zeitlinger
changed the title
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
martincostello
approved these changes
Apr 27, 2026
This was referenced Apr 27, 2026
Closed
Merged
zeitlinger
added a commit
that referenced
this pull request
Apr 27, 2026
### Added - add flint setup preflight migrations ([#233](#233)) - support managed linter configs and aqua-backed tool keys ([#228](#228)) - switch xmloxide to github backend ([#229](#229)) - add taplo formatter check ([#224](#224)) - *(init)* configure line length during init ([#218](#218)) ### Fixed - support renovate v43.136.3 ([#223](#223)) - switch yaml-lint to ryl ([#226](#226)) - *(ruff)* install via github releases ([#227](#227)) - resolve init rollout regressions ([#220](#220)) ### Other - reduce fake-bin fixture coverage ([#240](#240)) - *(deps)* update dependency npm:renovate to v43.141.1 ([#221](#221)) - guard fixture case groups ([#238](#238)) - *(deps)* update dependency grafana/flint to v0.20.4 ([#235](#235)) - *(deps)* lock file maintenance ([#237](#237)) - *(deps)* update dependency mise to v2026.4.19 ([#236](#236)) - *(deps)* update rust crate json5 to v1 ([#232](#232)) - *(deps)* update taiki-e/install-action digest to 787505c ([#219](#219)) - *(deps)* update dependency grafana/flint to v0.20.3 ([#225](#225)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add a registry-level test that validates the top-level
tests/cases/*groups stay aligned with the built-in check names, withgeneralas the only non-linter exception.Why
The fixture harness groups cases by the first path segment under
tests/cases. If a directory name drifts from the registered check name, the fixture layout silently stops matching the actual linter identity.This adds a guardrail so names like
ruff-formatvsruff-fmtare caught by tests instead of slipping into the case tree unnoticed.Validation
cargo test test_case_groups_match_registered_checksmise run lint:fixmise run lint