feat: support managed linter configs and aqua-backed tool keys by zeitlinger · Pull Request #228 · grafana/flint

zeitlinger · 2026-04-24T15:16:17Z

Summary

add config-dir-managed support for more linter configs, including taplo, cargo-fmt, actionlint, hadolint, codespell, editorconfig-checker, golangci-lint, ruff, rumdl, yaml-lint, and shellcheck
keep Biome opinionated around root biome.jsonc, reject legacy biome.json, and tighten rollout guards around unsupported repo-local configs and legacy tool keys
prefer aqua-backed mise keys where available, including taplo, ruff, and ktlint, plus aqua:owenlamont/ryl for yaml-lint
temporarily pin shellcheck back to github:koalaman/shellcheck until the Windows aqua fix lands in aquaproj/aqua-registry#52699
generate rumdl config with aligned Markdown table formatting by default
fold in follow-up polish for v2 agent guidance and make flint run --fix outcomes explicit

Notes

ruff-format now resolves through the ruff install key instead of pretending to be a separate installable tool
xmllint stays on github:jonwiggins/xmloxide for now and google-java-format stays on github:google/google-java-format
folded in the docs and --fix follow-up from fix: model --fix outcomes explicitly #222

Verification

mise exec -- cargo test -q
mise run lint:fix

Copilot

Pull request overview

Adds managed linter config support via FLINT_CONFIG_DIR (including new Taplo and cargo-fmt handling), strengthens “unsupported config” rollout guardrails, and formalizes Biome as a root-config exception (biome.jsonc only).

Changes:

Introduce LinterConfig (file vs “dir-if-any”) and support {CONFIG_ARGS} templating for command construction.
Expand registry metadata: baseline trigger becomes singular (baseline_config), add new unsupported-config fixtures, and broaden managed-config coverage across multiple linters.
Update flint init to generate Taplo + rustfmt managed configs and migrate Biome biome.json → biome.jsonc, with corresponding docs updates.

Reviewed changes

Copilot reviewed 63 out of 66 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/e2e.rs	Updates fake Biome script to understand `--config-path` and validate expected config presence.
tests/cases/ruff/clean/test.toml	Runs Ruff case with `FLINT_CONFIG_DIR` set.
tests/cases/ruff/clean/files/main.py	Adjusts fixture to rely on managed Ruff config (ignore unused import).
tests/cases/ruff/clean/files/.github/config/ruff.toml	Adds managed Ruff config file under config dir.
tests/cases/hadolint/clean/test.toml	Runs hadolint case with `FLINT_CONFIG_DIR` set.
tests/cases/hadolint/clean/files/Dockerfile	Adjusts fixture to rely on managed hadolint config ignores.
tests/cases/hadolint/clean/files/.github/config/.hadolint.yaml	Adds managed hadolint config under config dir.
tests/cases/golangci-lint/clean/test.toml	Runs golangci-lint case with `FLINT_CONFIG_DIR` set.
tests/cases/golangci-lint/clean/files/main.go	Adjusts fixture to rely on managed golangci-lint config disables.
tests/cases/golangci-lint/clean/files/.github/config/.golangci.yml	Adds managed golangci-lint config under config dir.
tests/cases/general/unsupported-taplo-config/test.toml	New fixture asserting Taplo rejects unsupported config locations.
tests/cases/general/unsupported-taplo-config/files/taplo.toml	Adds unsupported Taplo config in project root.
tests/cases/general/unsupported-taplo-config/files/mise.toml	Declares Taplo tool for the unsupported-config fixture.
tests/cases/general/unsupported-rustfmt-config/test.toml	New fixture asserting cargo-fmt rejects unsupported rustfmt configs.
tests/cases/general/unsupported-rustfmt-config/files/rustfmt.toml	Adds unsupported rustfmt config in project root.
tests/cases/general/unsupported-rustfmt-config/files/mise.toml	Declares rust tool + rustfmt component for the fixture.
tests/cases/general/unsupported-ruff-config/test.toml	New fixture asserting Ruff rejects `.ruff.toml`.
tests/cases/general/unsupported-ruff-config/files/mise.toml	Declares Ruff tool for the fixture.
tests/cases/general/unsupported-ruff-config/files/.ruff.toml	Adds unsupported Ruff config file.
tests/cases/general/unsupported-hadolint-config/test.toml	New fixture asserting hadolint rejects `.hadolint.yml`.
tests/cases/general/unsupported-hadolint-config/files/mise.toml	Declares hadolint tool for the fixture.
tests/cases/general/unsupported-hadolint-config/files/.hadolint.yml	Adds unsupported hadolint config file.
tests/cases/general/unsupported-golangci-lint-config/test.toml	New fixture asserting golangci-lint rejects `.golangci.yaml`.
tests/cases/general/unsupported-golangci-lint-config/files/mise.toml	Declares golangci-lint tool for the fixture.
tests/cases/general/unsupported-golangci-lint-config/files/.golangci.yaml	Adds unsupported golangci-lint config file.
tests/cases/general/unsupported-editorconfig-checker-config/test.toml	New fixture asserting editorconfig-checker rejects `.ecrc`.
tests/cases/general/unsupported-editorconfig-checker-config/files/mise.toml	Declares editorconfig-checker tool for the fixture.
tests/cases/general/unsupported-editorconfig-checker-config/files/.ecrc	Adds unsupported editorconfig-checker config file.
tests/cases/general/unsupported-codespell-config/test.toml	New fixture asserting codespell rejects `setup.cfg` config.
tests/cases/general/unsupported-codespell-config/files/setup.cfg	Adds unsupported codespell config via setup.cfg.
tests/cases/general/unsupported-codespell-config/files/mise.toml	Declares codespell tool for the fixture.
tests/cases/general/unsupported-biome-config/test.toml	New fixture asserting Biome rejects `biome.json`.
tests/cases/general/unsupported-biome-config/files/mise.toml	Declares biome tool for the fixture.
tests/cases/general/unsupported-biome-config/files/biome.json	Adds unsupported legacy Biome config name.
tests/cases/general/unsupported-actionlint-config/test.toml	New fixture asserting actionlint rejects legacy config location.
tests/cases/general/unsupported-actionlint-config/files/mise.toml	Declares actionlint tool for the fixture.
tests/cases/general/unsupported-actionlint-config/files/.github/actionlint.yml	Adds unsupported legacy actionlint config location.
tests/cases/general/init-rust/test.toml	Updates init output expectations (rustfmt + biome.jsonc).
tests/cases/general/init-idempotent/files/biome.jsonc	Adds idempotent-case Biome root JSONC config.
tests/cases/general/init-idempotent/files/.github/config/rustfmt.toml	Adds idempotent-case managed rustfmt config.
tests/cases/general/init-idempotent/files/.github/config/.taplo.toml	Adds idempotent-case managed Taplo config.
tests/cases/editorconfig-checker/clean/test.toml	Runs editorconfig-checker case with `FLINT_CONFIG_DIR` set.
tests/cases/editorconfig-checker/clean/files/hello.txt	Fixture change for editorconfig-checker behavior under managed config.
tests/cases/editorconfig-checker/clean/files/.github/config/.editorconfig-checker.json	Adds managed editorconfig-checker config under config dir.
tests/cases/codespell/clean/test.toml	Runs codespell case with `FLINT_CONFIG_DIR` set.
tests/cases/codespell/clean/files/README.md	Fixture change for codespell ignore-words behavior.
tests/cases/codespell/clean/files/.github/config/.codespellrc	Adds managed codespell config under config dir.
tests/cases/actionlint/clean/test.toml	Runs actionlint case with `FLINT_CONFIG_DIR` set.
tests/cases/actionlint/clean/files/.github/workflows/ci.yml	Fixture change for actionlint self-hosted runner labels.
tests/cases/actionlint/clean/files/.github/config/actionlint.yml	Adds managed actionlint config under config dir.
src/runner.rs	Adds `{CONFIG_ARGS}` support, introduces `LinterConfig`-aware resolution, and tests for new behavior.
src/registry/types.rs	Introduces `LinterConfig` enum and makes baseline trigger singular (`baseline_config`).
src/registry/tests.rs	Extends unsupported-key detection tests and updates registry docs table generation for `LinterConfig`.
src/registry/obsolete.rs	Adds legacy `npm:markdownlint-cli` to unsupported tool keys.
src/registry/mod.rs	Re-exports `LinterConfig`.
src/registry/checks.rs	Adds Taplo and cargo-fmt managed config handling, Biome root-config baseline, and new unsupported-config definitions.
src/main.rs	Updates unsupported-config error messaging, baseline detection logic, and JSON output to account for new config metadata.
src/init/mod.rs	Generates Taplo + rustfmt configs during init when relevant checks are selected.
src/init/config_files.rs	Implements config generation for Taplo and rustfmt; migrates Biome `biome.json` → `biome.jsonc`.
docs/linters.md	Documents Biome root-config exception and adds config rows for cargo-fmt and Taplo.
docs/cli.md	Clarifies `flint run` config behavior and notes Biome exception.
biome.jsonc	Adds root Biome config to the repo.
README.md	Updates config-dir documentation (including Biome exception) and reflows formatting.
AGENTS-V2.md	Adds guidance to treat root `biome.jsonc` as the only supported Biome config.
.markdownlint.json	Removes legacy markdownlint config file.
.github/agents/knowledge/linters.md	Updates guidance to treat Biome as a root-discovery exception rather than config-dir injected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Gregor Zeitlinger <[email protected]>

### Added - add flint setup preflight migrations ([#233](#233)) - support managed linter configs and aqua-backed tool keys ([#228](#228)) - switch xmloxide to github backend ([#229](#229)) - add taplo formatter check ([#224](#224)) - *(init)* configure line length during init ([#218](#218)) ### Fixed - support renovate v43.136.3 ([#223](#223)) - switch yaml-lint to ryl ([#226](#226)) - *(ruff)* install via github releases ([#227](#227)) - resolve init rollout regressions ([#220](#220)) ### Other - reduce fake-bin fixture coverage ([#240](#240)) - *(deps)* update dependency npm:renovate to v43.141.1 ([#221](#221)) - guard fixture case groups ([#238](#238)) - *(deps)* update dependency grafana/flint to v0.20.4 ([#235](#235)) - *(deps)* lock file maintenance ([#237](#237)) - *(deps)* update dependency mise to v2026.4.19 ([#236](#236)) - *(deps)* update rust crate json5 to v1 ([#232](#232)) - *(deps)* update taiki-e/install-action digest to 787505c ([#219](#219)) - *(deps)* update dependency grafana/flint to v0.20.3 ([#225](#225)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <[email protected]>

zeitlinger changed the title ~~feat: support config-dir-managed linter configs~~ feat: support managed linter configs and config rollout guards Apr 24, 2026

zeitlinger marked this pull request as ready for review April 24, 2026 17:02

zeitlinger requested a review from a team as a code owner April 24, 2026 17:02

Copilot AI review requested due to automatic review settings April 24, 2026 17:02

Copilot started reviewing on behalf of zeitlinger April 24, 2026 17:02 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Comment thread src/main.rs Outdated

Comment thread src/main.rs Outdated

Comment thread src/init/config_files.rs Outdated

zeitlinger mentioned this pull request Apr 25, 2026

fix: model --fix outcomes explicitly #222

Closed

zeitlinger changed the title ~~feat: support managed linter configs and config rollout guards~~ feat: support managed linter configs and aqua-backed tool keys Apr 25, 2026

zeitlinger force-pushed the codex/config-dir-managed-linters branch from 8bd54e4 to aa17b0f Compare April 25, 2026 12:22

zeitlinger added 17 commits April 25, 2026 12:29

fix: switch xmloxide to github backend

a18d71f

Signed-off-by: Gregor Zeitlinger <[email protected]>

feat: support config-dir-managed linter configs

0bc6e09

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: keep biome config at repo root

0fc7b58

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: update ruff fixture tool key

cf5cfdd

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: detect legacy markdownlint tool key

75a9acd

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: reject legacy biome config

d619ec1

Signed-off-by: Gregor Zeitlinger <[email protected]>

refactor: make baseline config singular

c319332

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: unify v2 repo migration cleanup

cff1ce5

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: address copilot config comments

702a7d4

Signed-off-by: Gregor Zeitlinger <[email protected]>

test: keep repo renovate config aligned

23861ad

Signed-off-by: Gregor Zeitlinger <[email protected]>

chore: update lockfile for renovate test

091553d

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: restore v1 and yamllint defaults

fbfa000

Signed-off-by: Gregor Zeitlinger <[email protected]>

refactor(registry): prefer aqua-backed linter keys

4662b30

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix: model --fix outcomes explicitly

922f4c3

Signed-off-by: Gregor Zeitlinger <[email protected]>

docs: update agent guidance for v2

0b3fe3a

Signed-off-by: Gregor Zeitlinger <[email protected]>

docs: inline v2 agent guidance

ef5f9be

Signed-off-by: Gregor Zeitlinger <[email protected]>

chore: keep v1 super-linter assets out of v2 changes

dcee158

Signed-off-by: Gregor Zeitlinger <[email protected]>

zeitlinger force-pushed the codex/config-dir-managed-linters branch from 6a262fb to dcee158 Compare April 25, 2026 12:35

zeitlinger added 3 commits April 25, 2026 12:37

docs: align migration note with aqua-backed yaml-lint

64fe0a6

Signed-off-by: Gregor Zeitlinger <[email protected]>

feat(init): write editorconfig line-length carve-outs

7034ab0

Signed-off-by: Gregor Zeitlinger <[email protected]>

feat(init): clean stale delegated line-length suppressions

e6bc24e

Signed-off-by: Gregor Zeitlinger <[email protected]>

zeitlinger added 6 commits April 25, 2026 14:01

refactor(init): split repo migration helpers

a23d568

Signed-off-by: Gregor Zeitlinger <[email protected]>

refactor(init): make linter section invite-only

17a48c6

Signed-off-by: Gregor Zeitlinger <[email protected]>

test(registry): skip shellcheck path check on windows

8f419f8

Signed-off-by: Gregor Zeitlinger <[email protected]>

ci: run registry path checks under mise

f8bece2

Signed-off-by: Gregor Zeitlinger <[email protected]>

ci: run tests via mise task

0f4a5b3

Signed-off-by: Gregor Zeitlinger <[email protected]>

ci: install mise tools before tests

c81041c

Signed-off-by: Gregor Zeitlinger <[email protected]>

martincostello reviewed Apr 25, 2026

View reviewed changes

Comment thread .github/workflows/lint.yml Outdated

Comment thread README.md Outdated

Comment thread README.md Outdated

Comment thread docs/cli.md

Comment thread docs/linters.md Outdated

zeitlinger added 4 commits April 25, 2026 16:51

fix(registry): pin shellcheck to github backend for now

82a6ef4

Signed-off-by: Gregor Zeitlinger <[email protected]>

fix(docs): align markdown notes and tables

19dffc6

Signed-off-by: Gregor Zeitlinger <[email protected]>

refactor(runner): make non-verbose noise filtering registry-driven

2b6a38c

Signed-off-by: Gregor Zeitlinger <[email protected]>

chore: self-apply managed lint config updates

7423f4d

Signed-off-by: Gregor Zeitlinger <[email protected]>

martincostello approved these changes Apr 25, 2026

View reviewed changes

zeitlinger enabled auto-merge (squash) April 25, 2026 18:30

zeitlinger merged commit 38d14ba into main Apr 25, 2026
13 checks passed

zeitlinger deleted the codex/config-dir-managed-linters branch April 25, 2026 18:34

This was referenced Apr 25, 2026

chore: release v0.20.5 #230

Closed

chore: release v0.21.0 #241

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support managed linter configs and aqua-backed tool keys#228

feat: support managed linter configs and aqua-backed tool keys#228
zeitlinger merged 30 commits intomainfrom
codex/config-dir-managed-linters

zeitlinger commented Apr 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zeitlinger commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeitlinger commented Apr 24, 2026 •

edited

Loading