fix: resolve init rollout regressions#220
Merged
zeitlinger merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
zeitlinger
force-pushed
the
codex/fix-init-rollout-regressions
branch
from
b37b9fe to
af6d29a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes flint init rollout regressions by relocating generated linter configs into FLINT_CONFIG_DIR, refining how [tools] entries are grouped around # Linters, and improving hook installation behavior for linked worktrees.
Changes:
- Write generated
.rumdl.tomland.yamllint.ymlunder the flint config dir (e.g..github/config) and update tests/cases accordingly. - Stop generating the
lint:pre-committask and update docs/tests to match. - Rework
[tools]normalization to keep non-linter tools above# Lintersand treat YAML as owned byyaml-lint(aligning with Markdown ownership byrumdl).
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cases/general/init-rust/test.toml | Updates expected init output and generated config contents/paths. |
| tests/cases/general/init-idempotent/files/.yamllint.yml | Removes legacy root-level yamllint config fixture. |
| tests/cases/general/init-idempotent/files/.github/config/.yamllint.yml | Adds new config-dir yamllint fixture with updated rules. |
| tests/cases/general/init-idempotent/files/.github/config/.rumdl.toml | Adds new config-dir rumdl fixture. |
| src/registry/mod.rs | Replaces toolchain grouping with linter_keys() for [tools] header grouping. |
| src/init/scaffold.rs | Removes lint:pre-commit generation; uses repo-aware hook path resolution. |
| src/init/mod.rs | Routes config generation/exclusions through FLINT_CONFIG_DIR; adds a normalization test. |
| src/init/generation.rs | Updates grouping logic to use linter_keys() and adjusts TOML key decoration handling. |
| src/init/config_files.rs | Moves rumdl/yamllint generation into config dir; expands ec-checker excludes to include YAML. |
| src/hook.rs | Computes hook destination via git rev-parse --git-common-dir; adds a linked-worktree test. |
| README.md | Removes documented lint:pre-commit task. |
| MIGRATION.md | Updates init behavior description and removes hook-task guidance. |
| .github/agents/knowledge/design.md | Documents updated YAML ownership and generated yamllint behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <[email protected]>
zeitlinger
force-pushed
the
codex/fix-init-rollout-regressions
branch
from
af6d29a to
7adbea7
Compare
martincostello
approved these changes
Apr 24, 2026
This was referenced Apr 24, 2026
Closed
Closed
Merged
zeitlinger
added a commit
that referenced
this pull request
Apr 27, 2026
### Added - add flint setup preflight migrations ([#233](#233)) - support managed linter configs and aqua-backed tool keys ([#228](#228)) - switch xmloxide to github backend ([#229](#229)) - add taplo formatter check ([#224](#224)) - *(init)* configure line length during init ([#218](#218)) ### Fixed - support renovate v43.136.3 ([#223](#223)) - switch yaml-lint to ryl ([#226](#226)) - *(ruff)* install via github releases ([#227](#227)) - resolve init rollout regressions ([#220](#220)) ### Other - reduce fake-bin fixture coverage ([#240](#240)) - *(deps)* update dependency npm:renovate to v43.141.1 ([#221](#221)) - guard fixture case groups ([#238](#238)) - *(deps)* update dependency grafana/flint to v0.20.4 ([#235](#235)) - *(deps)* lock file maintenance ([#237](#237)) - *(deps)* update dependency mise to v2026.4.19 ([#236](#236)) - *(deps)* update rust crate json5 to v1 ([#232](#232)) - *(deps)* update taiki-e/install-action digest to 787505c ([#219](#219)) - *(deps)* update dependency grafana/flint to v0.20.3 ([#225](#225)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FLINT_CONFIG_DIRlint:pre-commitand keep non-linter tools above# Lintersyaml-lintown YAML overlap foreditorconfig-checker, matchingrumdlfor MarkdownVerification
cargo testFLINT_CASES=yaml-lint cargo test cases -- --nocapturecargo test readme_linter_table_in_sync -- --nocapturemise run lint:fixContext
This bundles the init and ownership regressions found while migrating consumer repositories after
v0.20.4, so the next patch release can be used for the remaining rollout PRs.