feat(init): configure line length during init#218
Merged
zeitlinger merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable line-length preference to flint init, using it when generating init-owned formatting/config files (notably .editorconfig, .rumdl.toml, and .yamllint.yml) and refactors init generation code into smaller modules.
Changes:
- Adds an interactive left/right arrow control on the category-selection UI to set line length (default 120).
- Generates or patches
.editorconfigto includemax_line_lengthwhen not already set globally, and threads line length into.rumdl.toml/.yamllint.yml. - Splits init responsibilities into
config_filesandscaffoldmodules, updating Renovate metadata accordingly.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/init/ui.rs |
Adds interactive line-length adjustment to the category selector UI. |
src/init/mod.rs |
Threads selected line length through init flow; wires new modules and adds tests. |
src/init/config_files.rs |
New module for generating/patching init-owned config files (incl. .editorconfig). |
src/init/scaffold.rs |
New module for workflow/template + mise task/env scaffolding moved out of generation.rs. |
src/init/generation.rs |
Removes moved config/scaffold functions (now in config_files / scaffold). |
tests/cases/general/init-rust/test.toml |
Updates expected init output to include .editorconfig patching. |
tests/cases/general/init-idempotent/files/.editorconfig |
Updates fixture to include max_line_length. |
README.md |
Updates example config comment for base_branch. |
.github/renovate.json5 |
Points Renovate regex managers at the moved workflow template location. |
.github/renovate-tracked-deps.json |
Updates tracked-deps mapping to the new scaffold file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <[email protected]>
martincostello
approved these changes
Apr 23, 2026
This was referenced Apr 23, 2026
Closed
Closed
Merged
zeitlinger
added a commit
that referenced
this pull request
Apr 27, 2026
### Added - add flint setup preflight migrations ([#233](#233)) - support managed linter configs and aqua-backed tool keys ([#228](#228)) - switch xmloxide to github backend ([#229](#229)) - add taplo formatter check ([#224](#224)) - *(init)* configure line length during init ([#218](#218)) ### Fixed - support renovate v43.136.3 ([#223](#223)) - switch yaml-lint to ryl ([#226](#226)) - *(ruff)* install via github releases ([#227](#227)) - resolve init rollout regressions ([#220](#220)) ### Other - reduce fake-bin fixture coverage ([#240](#240)) - *(deps)* update dependency npm:renovate to v43.141.1 ([#221](#221)) - guard fixture case groups ([#238](#238)) - *(deps)* update dependency grafana/flint to v0.20.4 ([#235](#235)) - *(deps)* lock file maintenance ([#237](#237)) - *(deps)* update dependency mise to v2026.4.19 ([#236](#236)) - *(deps)* update rust crate json5 to v1 ([#232](#232)) - *(deps)* update taiki-e/install-action digest to 787505c ([#219](#219)) - *(deps)* update dependency grafana/flint to v0.20.3 ([#225](#225)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a line-length preference to
flint initand uses it when generating init-owned formatter/config files.120for--yesand non-custom flows..editorconfigwithmax_line_lengthwhen no explicit global value exists..rumdl.tomland.yamllint.yml.Validation
cargo testmise run lint:fix