fix(release): sequence release-pr after release and trigger binary build#184
Merged
zeitlinger merged 2 commits intomainfrom Apr 17, 2026
Merged
fix(release): sequence release-pr after release and trigger binary build#184zeitlinger merged 2 commits intomainfrom
zeitlinger merged 2 commits intomainfrom
Conversation
Release PR was computing the next version concurrently with the Release job creating the git tag. If Release PR won the race, it had no new tag as a baseline and included the full commit history in the changelog. Adding needs: [release] ensures the tag exists before release-pr determines what's changed since the last release. Signed-off-by: Gregor Zeitlinger <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the Release PR job runs only after the release job completes so the newly created git tag exists before release-plz computes the next changelog baseline, preventing the “full history” changelog race on main.
Changes:
- Add
needs: [release]to therelease-prjob to enforce ordering. - Add an inline comment documenting why the dependency exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…es tag GITHUB_TOKEN-created tags don't fire push:tags: triggers in other workflows. Use workflow_dispatch instead, same pattern as prometheus/client_java's release-please setup. Signed-off-by: Gregor Zeitlinger <[email protected]>
zeitlinger
changed the title
martincostello
approved these changes
Apr 17, 2026
Merged
zeitlinger
pushed a commit
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needs: [release]ensures the tag is created before the next release PR is computedGITHUB_TOKEN-created tags don't firepush: tags:triggers in other workflows — same limitation as release-pleaserelease.ymldirectly from the release job when a release is created (same pattern as prometheus/client_java)Test plan
release.ymltriggers automatically after the next release PR is merged