feat: add memberlist content size (bytes) to web page #889
Merged
Conversation
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
4 tasks
jesusvazquez
approved these changes
Jan 29, 2026
pracucci
added a commit
to grafana/mimir
that referenced
this pull request
Jan 30, 2026
#### What this PR does In this PR I'm updating dskit to get grafana/dskit#889 and adding the "Size" (in bytes) column to the memberlist web page. It can be useful to quickly have an idea of how big is an entry. Draft because it's based on grafana/dskit#889 that has not been merged yet. **Preview:** <img width="1370" height="680" alt="Screenshot 2026-01-29 at 15 38 42" src="https://github.com/user-attachments/assets/182f79c6-39e8-43ad-a3ba-11aa26e473f1" /> #### Which issue(s) this PR fixes or relates to N/A #### Checklist - [x] Tests updated. - [ ] Documentation added. - [ ] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. --------- Signed-off-by: Marco Pracucci <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Based on a feedback from @pstibrany, in this PR I'm adding the "Size" (in bytes) column to the memberlist web page. It can be useful to quickly have an idea of how big is an entry.
See grafana/mimir#14200 to see a preview in Mimir.
Which issue(s) this PR fixes:
N/A
Checklist