grpcclient: Support custom gRPC compressors#583
Merged
Conversation
aknuds1
force-pushed
the
arve/grpc-comp-custom
branch
from
54e87f9 to
623d4c9
Compare
pstibrany
reviewed
Sep 17, 2024
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Looks on the right path.
pstibrany
approved these changes
Sep 17, 2024
4 tasks
Collaborator
Author
|
Thanks for the review @pstibrany - I'm going to add tests before finalizing. |
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/grpc-comp-custom
branch
from
184dcac to
a871de8
Compare
4 tasks
Signed-off-by: Arve Knudsen <[email protected]>
Collaborator
Author
|
Added tests. |
pstibrany
reviewed
Sep 19, 2024
Comment on lines
+11
to
+12
| func TestConfig(t *testing.T) { | ||
| t.Run("custom compressors", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func TestConfig(t *testing.T) { | |
| t.Run("custom compressors", func(t *testing.T) { | |
| func TestCustomCompressorsConfig(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
I guess it's a style issue, but to me it made sense to make the root test for the Config class, and then have sub tests for functionalities.
Contributor
There was a problem hiding this comment.
yeah, not important at all. It just look weird to me to have top-level test function with single t.Run call :) Feel free to ignore.
Collaborator
Author
There was a problem hiding this comment.
Hopefully there will be more sub-tests :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support to the
grpcclientpackage for custom gRPC compressors.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]