spanLogger: remove duplicate noopSpan implementation#280
Merged
Conversation
This appears to have been copied unnecssarily from upstream. Signed-off-by: Bryan Boreham <[email protected]>
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Apr 12, 2023
This brings in grafana/dskit#280 and grafana/dskit#281.
1 task
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Apr 12, 2023
* Upgrade to latest dskit version. This brings in grafana/dskit#280 and grafana/dskit#281. * Add changelog entry.
5 tasks
charleskorn
pushed a commit
that referenced
this pull request
Aug 3, 2023
Enable Prometheus native histograms for request_duration_seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Remove some code we don't need.
This appears to have been copied unnecssarily from upstream.
I checked using
GOSSAFUNCthat the generated code references variablegithub.com/opentracing/opentracing-go.defaultNoopSpanand does not do an extra function call.Checklist
CHANGELOG.mdupdated