Remove trivial "util" exported package#247
Merged
56quarters merged 2 commits intomainfrom Jan 4, 2023
Merged
Conversation
This package was never meant to be exported but the change got lost as part of [code review](#239 (comment)). Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
charleskorn
approved these changes
Jan 4, 2023
Contributor
charleskorn
left a comment
charleskorn
left a comment
There was a problem hiding this comment.
LGTM, but we may be able to replace our slices.Contains with the implementation in golang.org/x/exp/slices instead.
charleskorn
pushed a commit
that referenced
this pull request
Aug 3, 2023
…-exemplars Revert "Add user and org labels to observed exemplars"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Replaced with an internal-only function. This package was never meant to be exported but the change got lost as part of code review.
Signed-off-by: Nick Pillitteri [email protected]
Which issue(s) this PR fixes:
See #239
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]