Merged
Conversation
Instead of having a const with a huge string, now we have .gohtml files that are properly understood by the IDEs (at least by Goland) and we embed them into global string vars using the //go:embed directive. Also standarized how both status pages templates for ring and memberlist are initialized. Signed-off-by: Oleg Zaytsev <[email protected]>
2 tasks
Contributor
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Instead of having a const with a huge string, now we have
.gohtmlfiles that are properly understood by the IDEs (at least by Goland) and we embed them into global string vars using the//go:embeddirective.Also standarized how both status pages templates for ring and memberlist are initialized.
Which issue(s) this PR fixes:
Cleaning up for #148
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX](not needed since this only changes unexported vars)