pkg/metrics/wal: remove deleted series from WAL sooner#5068
Merged
tpaschalis merged 2 commits intoSep 4, 2023
Conversation
This change causes deleted series to be deleted earlier based on the last segment involved in the checkpoint rather than the first segment involved in the checkpoint. This will then cause the next truncate to be more aggressive with dropped series, which should help free memory associated with deleted series in remote_write sooner. Mirrors prometheus/prometheus#12297 from @bboreham.
rfratto
changed the title
rfratto
changed the title
tpaschalis
enabled auto-merge (squash)
September 4, 2023 07:51
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change causes deleted series to be deleted earlier based on the last segment involved in the checkpoint rather than the first segment involved in the checkpoint.
This will then cause the next truncate to be more aggressive with dropped series, which should help free memory associated with deleted series in remote_write sooner.
Mirrors prometheus/prometheus#12297 from @bboreham.