Skip to content

Ensure BuildOperationQueue will progress without extra leases#37629

Merged
blindpirate merged 1 commit intoreleasefrom
ot/fix/remove-item-only-after-locked
Apr 23, 2026
Merged

Ensure BuildOperationQueue will progress without extra leases#37629
blindpirate merged 1 commit intoreleasefrom
ot/fix/remove-item-only-after-locked

Conversation

@octylFractal
Copy link
Copy Markdown
Member

Fixes #37613

This is an alternative to reverting #36952.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@octylFractal octylFractal added this to the 9.5.0 RC4 milestone Apr 22, 2026
@octylFractal octylFractal requested a review from jvandort April 22, 2026 05:40
@octylFractal octylFractal self-assigned this Apr 22, 2026
@octylFractal octylFractal added a:bug This doesn't work as expected in:workers labels Apr 22, 2026
@big-guy big-guy requested a review from ghale April 22, 2026 17:20
@octylFractal

This comment has been minimized.

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Copy Markdown
Collaborator

The following builds have passed:

@octylFractal octylFractal marked this pull request as ready for review April 22, 2026 19:02
Copy link
Copy Markdown
Member

@ghale ghale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor issue with a comment if you want to fix it, but it's not a blocking issue at all.

@octylFractal octylFractal force-pushed the ot/fix/remove-item-only-after-locked branch from 6c24ca0 to acdf0c3 Compare April 22, 2026 21:21
@octylFractal octylFractal added this pull request to the merge queue Apr 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@octylFractal
Copy link
Copy Markdown
Member Author

@bot-gradle test this

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Copy Markdown
Collaborator

The following builds have passed:

@blindpirate blindpirate added this pull request to the merge queue Apr 23, 2026
Merged via the queue into release with commit d5cfd07 Apr 23, 2026
19 checks passed
@blindpirate blindpirate deleted the ot/fix/remove-item-only-after-locked branch April 23, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:bug This doesn't work as expected in:workers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants