Skip to content

[prone] Apply UnusedMethod in language-native#35542

Merged
ov7a merged 1 commit intogradle:masterfrom
Pankraz76:tryout-fix-IncrementalCompileProcessor
Nov 5, 2025
Merged

[prone] Apply UnusedMethod in language-native#35542
ov7a merged 1 commit intogradle:masterfrom
Pankraz76:tryout-fix-IncrementalCompileProcessor

Conversation

@Pankraz76
Copy link
Copy Markdown

@Pankraz76 Pankraz76 commented Nov 3, 2025

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

extracting:

#35470 (comment)

Architecture Violation [Priority: MEDIUM] - Rule 'classes that are in Gradle internal API packages and classes written in Java or Groovy and not synthetic classes and not anonymous classes should be annotated (directly or via its package) with @org.jspecify.annotations.NullMarked' was violated (1 times):
Class <org.gradle.language.nativeplatform.internal.incremental.IncrementalCompileProcessor$1$ProcessSourceFilesDetails> is not annotated (directly or via its package) with @org.jspecify.annotations.NullMarked in (IncrementalCompileProcessor.java:0)
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that are in Gradle internal API packages and classes written in Java or Groovy and not synthetic classes and not anonymous classes should be annotated (directly or via its package) with @org.jspecify.annotations.NullMarked' was violated (1 times):
Class <org.gradle.language.nativeplatform.internal.incremental.IncrementalCompileProcessor$1$ProcessSourceFilesDetails> is not annotated (directly or via its package) with @org.jspecify.annotations.NullMarked in (IncrementalCompileProcessor.java:0)
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at org.gradle.architecture.test.FreezeInstructionsPrintingArchRule.check(FreezeInstructionsPrintingArchRule.java:32)
	at com.tngtech.archunit.junit.internal.ArchUnitTestDescriptor$ArchUnitRuleDescriptor.execute(ArchUnitTestDescriptor.java:166)
	at com.tngtech.archunit.junit.internal.ArchUnitTestDescriptor$ArchUnitRuleDescriptor.execute(ArchUnitTestDescriptor.java:149)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Nov 3, 2025
Pankraz76
Pankraz76 commented Nov 3, 2025
View reviewed changes
Comment thread ...tive/language-native/src/main/java/org/gradle/language/internal/DefaultBinaryCollection.java
}

// Mix in some Groovy DSL support. Should decorate instead
public void configure(Closure<?> closure) {
Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expecting cause for:

org.gradle.api.internal.provider.MissingValueException: Cannot query the value of extension 'develocity' property 'server' because it has no value available.

Pankraz76
Pankraz76 commented Nov 3, 2025
View reviewed changes
Comment thread ...ava/org/gradle/language/nativeplatform/internal/incremental/IncrementalCompileProcessor.java

@Override
public BuildOperationDescriptor.Builder description() {
ProcessSourceFilesDetails operationDetails = new ProcessSourceFilesDetails(sourceFiles.size());
Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off topic but still justifiable as just a refactoring allowing the change. Actually did only to have unrelated change wanted to check this initially.

Let me know if acceptable or undo, thanks.

@ov7a ov7a self-assigned this Nov 5, 2025
@ov7a ov7a added in:building-gradle gradle/gradle build and removed to-triage labels Nov 5, 2025
ov7a
ov7a approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ov7a ov7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

This PR is complete and simple enough, it will be merged immediately.

@ov7a ov7a added this pull request to the merge queue Nov 5, 2025
@bot-gradle bot-gradle added this to the 9.3.0 RC1 milestone Nov 5, 2025
Merged via the queue into gradle:master with commit c890af4 Nov 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ov7a ov7a ov7a approved these changes

@octylFractal octylFractal Awaiting requested review from octylFractal octylFractal is a code owner automatically assigned from gradle/bt-jvm

Assignees

@ov7a ov7a

Labels

from:contributor PR by an external contributor in:building-gradle gradle/gradle build

Projects

None yet

Milestone

9.3.0 RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@Pankraz76 @ov7a @bot-gradle