Skip to content

[prone] Apply UnusedMethod#35470

Merged
ov7a merged 1 commit intogradle:masterfrom
Pankraz76:pr-fix-UnusedMethod
Nov 5, 2025
Merged

[prone] Apply UnusedMethod#35470
ov7a merged 1 commit intogradle:masterfrom
Pankraz76:pr-fix-UnusedMethod

Conversation

@Pankraz76
Copy link
Copy Markdown

@Pankraz76 Pankraz76 commented Oct 25, 2025 •
edited
Loading

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

related to:

@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Oct 25, 2025
Pankraz76
Pankraz76 commented Oct 25, 2025
View reviewed changes
Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 ct.

Comment thread ...onfiguration/model-core/src/main/java/org/gradle/api/internal/provider/AbstractProperty.java Outdated
Comment thread ...nfiguration/model-core/src/main/java/org/gradle/api/internal/provider/FilteringProvider.java
Comment thread platforms/jvm/jacoco/src/main/java/org/gradle/testing/jacoco/plugins/JacocoPluginExtension.java Outdated
Comment thread ...ava/org/gradle/language/nativeplatform/internal/incremental/IncrementalCompileProcessor.java Outdated
ProcessSourceFilesDetails operationDetails = new ProcessSourceFilesDetails(sourceFiles.size());
return BuildOperationDescriptor
.displayName("Processing source files")
.details(operationDetails);
Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 Oct 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems never considered, as toString does not cover the fields, like a record or data class.

Comment thread ...acts/ivyservice/ivyresolve/verification/report/HtmlDependencyVerificationReportRenderer.java
Comment thread ...acts/ivyservice/ivyresolve/verification/report/HtmlDependencyVerificationReportRenderer.java Outdated
Comment thread ...ent/src/main/java/org/gradle/api/internal/artifacts/DefaultDependencyManagementServices.java
Comment thread platforms/software/dependency-management/build.gradle.kts Outdated
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Oct 25, 2025

updated null config, like suggested: ./gradlew architecture-test:test -ParchunitRefreeze

@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Oct 25, 2025 •
edited
Loading

Task :model-core:checkstyleMain
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/gradle/platforms/core-configuration/model-core/src/main/java/org/gradle/api/internal/provider/FlatMapProvider.java:57:53: '(' is followed by whitespace. [ParenPad]

could automate the check issues.

had to fix unused imports multiple times and whitespaces by hand.

Would like to run the default command ./gradlew clean spotlessApply build -x test

@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Oct 25, 2025 •
edited
Loading

item to fix:

org.gradle.api.internal.provider.MissingValueException: Cannot query the value of extension 'develocity' property 'server' because it has no value available.

assuming its needed by:

DefaultBinaryCollection

@ov7a ov7a self-assigned this Oct 27, 2025
@ov7a ov7a removed the to-triage label Oct 27, 2025
@tresat tresat removed their request for review October 27, 2025 21:19
ov7a
ov7a requested changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ov7a ov7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pankraz76 Please look at my comments on the previous PR you asked me to review
https://github.com/Pankraz76/gradle/pull/21

Overall, it would be nice to remove UnusedMethod from disabled checks, but please move out unrelated changes from this PR (even if they are suggested by IDE).

Comment thread ...onfiguration/model-core/src/main/java/org/gradle/api/internal/provider/AbstractProperty.java Outdated
@ov7a ov7a added the pending:feedback Indicates that changes or additional info are required, and the issue will be closed without them label Oct 29, 2025
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Oct 29, 2025

please move out unrelated changes from this PR

done.

ov7a
ov7a requested changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ov7a ov7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, PTAL

Comment thread platforms/jvm/jacoco/src/main/java/org/gradle/testing/jacoco/plugins/JacocoPluginExtension.java Outdated
Comment thread ...tive/language-native/src/main/java/org/gradle/language/internal/DefaultBinaryCollection.java Outdated
Comment thread ...ent/src/main/java/org/gradle/api/internal/artifacts/DefaultDependencyManagementServices.java Outdated
Comment thread ...ava/org/gradle/language/nativeplatform/internal/incremental/IncrementalCompileProcessor.java Outdated
@ov7a

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@ov7a ov7a removed the pending:feedback Indicates that changes or additional info are required, and the issue will be closed without them label Oct 29, 2025
@bot-gradle
Copy link
Copy Markdown
Collaborator

bot-gradle commented Oct 29, 2025

The following builds have failed:

@ov7a
Copy link
Copy Markdown
Member

ov7a commented Oct 29, 2025

@Pankraz76 Please address sanity check errors

@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Oct 30, 2025 •
edited
Loading

again this issue:

org.gradle.api.internal.provider.MissingValueException: Cannot query the value of extension 'develocity' property 'server' because it has no value available.

Dont know whats the root cause for this.

@cobexer cobexer removed the request for review from a team October 30, 2025 11:21
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Nov 1, 2025

assuming build to fail now as considered in:

Pankraz76
Pankraz76 commented Nov 1, 2025
View reviewed changes
Copy link
Copy Markdown
Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange arch unit test issue.

Comment thread ...ava/org/gradle/language/nativeplatform/internal/incremental/IncrementalCompileProcessor.java
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Nov 3, 2025

need to wait for enabler, as change seems to fail over here constantly...

ov7a
ov7a requested changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ov7a ov7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert nullability-related changes.

Since you extracted some of the changes to

  • #35542
    I also expect a rebase after it gets merged

Comment thread ...nfiguration/model-core/src/main/java/org/gradle/api/internal/provider/FilteringProvider.java
Comment thread testing/architecture-test/src/changes/archunit-store/internal-api-nullability.txt
@ov7a ov7a added the in:building-gradle gradle/gradle build label Nov 5, 2025
[prone] Apply UnusedMethod
2209924 
Signed-off-by: Vincent Potucek <[email protected]>
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Nov 5, 2025

@bot-gradle test this

now this should hopefully pass.

@bot-gradle
Copy link
Copy Markdown
Collaborator

bot-gradle commented Nov 5, 2025

Sorry but I'm afraid you're not allowed to do this.

@ov7a ov7a added this pull request to the merge queue Nov 5, 2025
@bot-gradle bot-gradle added this to the 9.3.0 RC1 milestone Nov 5, 2025
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented Nov 5, 2025 •
edited
Loading

if no problem lets test this.

actually we shoud have to do both to be really able to compare as the error was happening just on second stage firing big test cases.

@ov7a

Merged via the queue into gradle:master with commit c51d289 Nov 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ov7a ov7a ov7a approved these changes

@reinsch82 reinsch82 Awaiting requested review from reinsch82 reinsch82 is a code owner automatically assigned from gradle/bt-tide

@mlopatkin mlopatkin Awaiting requested review from mlopatkin mlopatkin is a code owner automatically assigned from gradle/bt-cortex

@6hundreds 6hundreds Awaiting requested review from 6hundreds 6hundreds is a code owner automatically assigned from gradle/bt-cortex

Assignees

@ov7a ov7a

Labels

from:contributor PR by an external contributor in:building-gradle gradle/gradle build

Projects

None yet

Milestone

9.3.0 RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@Pankraz76 @ov7a @bot-gradle