Revert #34262 (Escape double quotes in Java arguments on windows)#35080
Merged
Revert #34262 (Escape double quotes in Java arguments on windows)#35080
Conversation
Member
Author
|
@bot-gradle test this |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The following builds have failed: |
cobexer
approved these changes
Sep 22, 2025
Member
cobexer
left a comment
cobexer
left a comment
There was a problem hiding this comment.
I did not review the changes, but wan't to make it explicit that this is fine to merge to release after it got reviewed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although #34262 fixed the issue where quotes were being stripped from arguments, it introduced breaking behavior when the expectation is that the quotes should be stripped while processing the arguments. In other words, there are cases where the expectation is that the quotes are stripped and there are cases where the expectation is that they should be preserved. We don't have a good way to guess which the user wants, so changing the behavior becomes a breaking change for someone.
We're reverting this for now to return to the previous behavior. We may consider doing something to improve the situation in Gradle 10.0.
Reverts #34262
Fixes https://github.com/gradle/gradle-private/issues/4847
Reviewing cheatsheet
Before merging the PR, comments starting with