Fix issue with double quotes when launching java processes on windows #34262
Merged
Fix issue with double quotes when launching java processes on windows #34262
Conversation
ghale
changed the title
ljacomet
reviewed
Jul 18, 2025
ljacomet
requested changes
Jul 24, 2025
Member
ljacomet
left a comment
ljacomet
left a comment
There was a problem hiding this comment.
See previous comments.
💅 Also remove the added blank line in getAllJvmArgs
wheeleme
force-pushed
the
gh/issues/6072
branch
2 times, most recently
from
341b097 to
1c36187
Compare
Renamed setAllArgsWindows to escapeQuotes
… cover other situations beyond java. # Conflicts: # platforms/jvm/language-java/src/integTest/groovy/org/gradle/integtests/ExecIntegrationTest.groovy
wheeleme
force-pushed
the
gh/issues/6072
branch
from
541e0b7 to
f93440d
Compare
Contributor
Author
|
@bot-gradle test this |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The following builds have passed: |
Contributor
Author
|
@ljacomet Could you take a second look when you have a chance? |
ljacomet
approved these changes
Aug 25, 2025
cobexer
added a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Christoph Obexer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6072
Context
User encountered issue where Java process on Windows would drop double quotes in Java Processes. This PR checks for double quotes and escapes them so Windows interprets them correctly.
Reviewing cheatsheet
Before merging the PR, comments starting with