Fix native plugins to be configuration cache compatible#30161
Merged
Conversation
alllex
approved these changes
Aug 13, 2024
alllex
left a comment
Member
There was a problem hiding this comment.
Great coverage improvement from relatively small production change 👍
Collaborator
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 14, 2024
This was referenced Aug 23, 2024
cobexer
added a commit
that referenced
this pull request
Oct 22, 2024
…y that was fixed in #30161 Signed-off-by: Christoph Obexer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The unit test plugins are not yet compatible and there are some tests that could be made compatible.
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective.<subproject>/src/test) to verify logic../gradlew sanityCheck../gradlew <changed-subproject>:quickTest.Reviewing cheatsheet
Before merging the PR, comments starting with