Skip to content

Fix native plugins to be configuration cache compatible#30161

Merged
blindpirate merged 8 commits into
masterfrom
am/native-cc
Aug 14, 2024
Merged

Fix native plugins to be configuration cache compatible#30161
blindpirate merged 8 commits into
masterfrom
am/native-cc

Conversation

@adammurdoch

Copy link
Copy Markdown
Contributor

Context

The unit test plugins are not yet compatible and there are some tests that could be made compatible.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@adammurdoch
adammurdoch requested a review from a team as a code owner August 13, 2024 00:03
@adammurdoch
adammurdoch requested review from a team August 13, 2024 00:03
@adammurdoch
adammurdoch requested a review from a team as a code owner August 13, 2024 00:03
@adammurdoch adammurdoch self-assigned this Aug 13, 2024
@adammurdoch adammurdoch added the in:native-platform c, cpp, swift and other native languages support, etc label Aug 13, 2024
@adammurdoch adammurdoch added this to the 8.11 RC1 milestone Aug 13, 2024
@cobexer
cobexer removed the request for review from a team August 13, 2024 05:42

@alllex alllex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great coverage improvement from relatively small production change 👍

@lkasso lkasso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting release notes!

@adammurdoch
adammurdoch added this pull request to the merge queue Aug 13, 2024
@bot-gradle

Copy link
Copy Markdown
Collaborator

The merge queue build has failed. Click here to see all failures.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@blindpirate
blindpirate added this pull request to the merge queue Aug 14, 2024
Merged via the queue into master with commit 98f0db0 Aug 14, 2024
@blindpirate
blindpirate deleted the am/native-cc branch August 14, 2024 07:36
@mlopatkin mlopatkin linked an issue Aug 23, 2024 that may be closed by this pull request
cobexer added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:native-platform c, cpp, swift and other native languages support, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make cpp-application plugin support the configuration cache

5 participants