Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework plugin classloader hierarchy #25616

Open
4 tasks
mlopatkin opened this issue Jul 5, 2023 · 3 comments
Open
4 tasks

Rework plugin classloader hierarchy #25616

mlopatkin opened this issue Jul 5, 2023 · 3 comments
Labels
a:epic @configuration-cache in:plugin-management

Comments

@mlopatkin
Copy link
Member

mlopatkin commented Jul 5, 2023 •
edited
Loading

Our current approach of having (roughly) per-project classloaders is problematic in certain cases, especially when plugins try to talk to each other.

Tasks
Preview Give feedback
  1. Using plugins DSL in settings causes unexpected class loading setup #18586
    a:bug in:build-services in:plugin-development
  2. Build services can only be registered if the set of applied plugins is the same on all projects #17559
    @configuration-cache a:bug in:build-services
    bamboo
  3. Buildscript classpath of submodules is wrongly resolved #12572
    a:bug in:buildscript-compilation in:plugin-management
  4. buildSrc dependencies leaks are not visible in gradlew buildEnvironment #8301
    a:bug in:build-src in:buildscript-compilation in:plugin-management in:reporting-tasks
@yogurtearl
Copy link
Contributor

Other things to consider:

  • Having many version of the same Classs loaded by different classloaders potentially has a high memory cost (uses more Metaspace)
  • the "per-project classloaders" are not well documented, which makes them extra surprising. Whatever the new solution is it should be well documented.

@ov7a ov7a mentioned this issue Aug 4, 2023
Open
@ljacomet ljacomet mentioned this issue Sep 4, 2023
Open
@yogurtearl
Copy link
Contributor

Another classloader issue with testing plugins using GradleRunner and withPluginClasspath: #21637

@TWiStErRob TWiStErRob mentioned this issue Oct 12, 2023
Open
@yogurtearl yogurtearl mentioned this issue Feb 28, 2024
Open
@climategadgets climategadgets mentioned this issue Mar 20, 2024
Open
@jjohannes jjohannes mentioned this issue Aug 19, 2024
Open
@ljacomet ljacomet mentioned this issue Oct 22, 2024
Open
@yogurtearl yogurtearl mentioned this issue Dec 17, 2024
Open
@ALikhachev
Copy link
Contributor

One more case: KT-57162
KGP is loaded by classloader of the root project. Additionally, AGP is loaded in the classloader of a child project. KGP applied in the child project cannot interact with AGP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:epic @configuration-cache in:plugin-management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eskatos @yogurtearl @ALikhachev @mlopatkin