Add a check for the minimal GraalVM version#353
Merged
melix merged 1 commit intograalvm:masterfrom Oct 31, 2022
Merged
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
melix
requested changes
Oct 28, 2022
Collaborator
melix
left a comment
melix
left a comment
There was a problem hiding this comment.
I'm wondering if it works for dev (snapshot) versions too.
...ve-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/tasks/BuildNativeImageTask.java
Outdated
Show resolved
Hide resolved
common/utils/src/test/java/org/graalvm/buildtools/utils/NativeImageUtilsTest.java
Show resolved
Hide resolved
common/utils/src/main/java/org/graalvm/buildtools/utils/NativeImageUtils.java
Show resolved
Hide resolved
sdeleuze
force-pushed
the
requiredVersion
branch
from
ccb866e to
222a6cb
Compare
Collaborator
Author
|
It works for snapshots, this is tested in |
sdeleuze
force-pushed
the
requiredVersion
branch
from
222a6cb to
b32f853
Compare
This commit adds a new Gradle and Maven requiredVersion configuration option that specifies the minimal GraalVM version and can be set to MAJOR, MAJOR.MINOR or MAJOR.MINOR.PATCH. Closes graalvmgh-346
sdeleuze
force-pushed
the
requiredVersion
branch
from
b32f853 to
fc77a3e
Compare
Collaborator
Author
|
@melix I think I have taken in account your feedback, please let me know if that's ok or if you think I should change something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new Gradle and Maven requiredVersion configuration option that specifies the minimal GraalVM version and can be set to
MAJOR,MAJOR.MINORorMAJOR.MINOR.PATCH.Closes gh-346