Fix functional tests for MacOS users#321
Merged
melix merged 1 commit intograalvm:masterfrom Oct 5, 2022
Merged
Conversation
Update `AbstractGraalVMMavenFunctionalTest` web server setup to use real paths. Prior to this commit, when running the functional tests on MacOS the web server would not serve the `target/repo.zip` file. This is due to the fact that the temp folder on MacOS can be a symlink which by default Jetty will not serve. Switching the resource base to the real folder fixes the problem.
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. |
Collaborator
|
looks good to me |
oracle-contributor-agreement
bot
added
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working on the codebase I found that functional tests fail on MacOS. The folling pull-request fixes the issue.