Remove num_workgroups builtin variable #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gpuweb#920 There's no simple translation into HLSL, so the feature has been removed from WebGPU MVP.
dneto0
added
wgsl
kvark
approved these changes
Jul 22, 2020
dj2
approved these changes
Jul 22, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…puweb#944) * Implement api,operation,command_buffer,render,state_tracking:* -- Part IV This patch adds the last part of the below WebGPU CTS: Implement api,operation,command_buffer,render,state_tracking:* - Test that drawing after having set vertex buffer slots not used by the pipeline. - Test that setting / not setting the index buffer does not impact a non-indexed draw. fixes gpuweb#877 * Address reviewer's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920
There's no simple translation into HLSL, so the feature has
been removed from WebGPU MVP.