Add description for minBufferBindingSize in BindGroupLayout #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
A tiny change to make bind group layout description complete, because we have already described every other parameter but not this one. |
kvark
approved these changes
Jul 13, 2020
spec/index.bs
Outdated
| {{GPUBindingType/"uniform-buffer"}}, | ||
| {{GPUBindingType/"storage-buffer"}}, or | ||
| {{GPUBindingType/"readonly-storage-buffer"}}, | ||
| this indicates the minimum buffer binding size. |
Contributor
There was a problem hiding this comment.
this is still optional for these types, maybe we can reword it "this *may* contain the minimum buffer binding size?
Author
There was a problem hiding this comment.
Then I want to change "this contains" to "this may contain" for "hasDynamicOffset" and "multisampled" too, in order to make them consistent (at least within BindGroupLayout). Does this sound good? @kvark
Contributor
There was a problem hiding this comment.
No. hasDynamicOffset and multisampled are always applicable to the relevant binding types. At the same time, minBufferBindingSize is optional.
Richard-Yunchao
force-pushed
the
add-description-for-minBufferBindingSize-in-BGL
branch
from
a43a1b4 to
0803591
Compare
kvark
approved these changes
Jul 13, 2020
JusSn
approved these changes
Jul 13, 2020
kainino0x
approved these changes
Jul 13, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
The changes to check for exceptions being thrown in gpuweb#1529 should only apply to cases where we are testing for an required feature being enabled. The updates to createBindGroupLayout.spec.ts were unnecessary and have started causing failures. FYI @Gyuyoung Issue: gpuweb#919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff