[wgsl] Rename kill to discard. #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL updates the name of the kill command to be discard. Fixes #911
kvark
approved these changes
Jul 9, 2020
dneto0
approved these changes
Jul 14, 2020
kdashg
approved these changes
Jul 14, 2020
Contributor
|
Discussed at 2020-07-14 meeting. Resolution was to accept this PR, but put a note saying there needs to be an investigation of the various API behaviours (new issue). |
kdashg
added a commit
to kdashg/gpuweb
that referenced
this pull request
May 25, 2022
HLSL has "demote (to helper)" behavior for `discard`, but GLSL has "kill" behavior. `kill` is less ambiguous. "Kill" is the verb used by e.g. SPIR-V, and it more clearly contrasts with "demote" as a verb for the HLSL `discard` behavior. This effectively reverts gpuweb#918.
kdashg
added a commit
to kdashg/gpuweb
that referenced
this pull request
May 28, 2022
HLSL has "demote (to helper)" behavior for `discard`, but GLSL has "terminate" behavior. `terminate` is less ambiguous. "Terminate" is the verb used by e.g. SPIR-V, and it more clearly contrasts with "demote" as a verb for the HLSL `discard` behavior. This kind of reverts gpuweb#918.
kdashg
added a commit
to kdashg/gpuweb
that referenced
this pull request
May 28, 2022
HLSL has "demote (to helper)" behavior for `discard`, but GLSL has "terminate" behavior. `terminate` is less ambiguous. "Terminate" is the verb used by e.g. SPIR-V, and it more clearly contrasts with "demote" as a verb for the HLSL `discard` behavior. Also reserve `kill`, just in case. This kind of reverts gpuweb#918.
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL updates the name of the kill command to be discard.
Fixes #911