Replace DOMString with USVString for wgsl and debug strings#787
Merged
kainino0x merged 1 commit intogpuweb:masterfrom May 19, 2020
Merged
Replace DOMString with USVString for wgsl and debug strings#787kainino0x merged 1 commit intogpuweb:masterfrom
kainino0x merged 1 commit intogpuweb:masterfrom
Conversation
kvark
approved these changes
May 19, 2020
Contributor
Author
|
Merging now since Justin and I already discussed this in depth. I don't think it really needs review from other folks. (I'm sure it'll get flagged later if someone feels strongly this is the wrong way to go.) |
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue for context.
Note: This is strictly breaking, but changing back from USVString to DOMString would be non-breaking.
Issue: #784
Preview | Diff